Opened 6 years ago

Closed 4 years ago

Last modified 4 years ago

#4622 closed enhancement (fixed)

Update generate_icons.py script to use the new ZMQ variant of OMPython

Reported by: dietmarw Owned by: alash325
Priority: high Milestone: 1.16.0
Component: OMPython Version: v1.13.0-dev-nightly
Keywords: Cc:

Description

OM ships with the script OMCompiler/Examples/generate_icons.py which gets deployed (at least on Linux) under /usr/share/doc/omc/testmodels/generate_icons.py. When working on the new streamlined ModelicaByExample CI configuration I noticed that this script is still using the old OmniORB interface. It would be nice if the script would be updated to us the ZMQ variant instead since this works on Python 2 and 3.

Change History (7)

comment:1 Changed 6 years ago by sjoelund.se

Feel free to fix the script. It seems to use Python syntax so you probably need to run some 2to3 conversion on it as well.

comment:3 Changed 5 years ago by casella

  • Milestone changed from 1.13.0 to 1.14.0

Rescheduled to 1.14.0 after 1.13.0 releasee

comment:4 Changed 4 years ago by casella

  • Milestone changed from 1.14.0 to 1.16.0

Releasing 1.14.0 which is stable and has many improvements w.r.t. 1.13.2. This issue is rescheduled to 1.16.0

comment:5 Changed 4 years ago by dietmarw

It looks like this issue has been fixed a long time ago by the provided PR that also got merged. Any other reason why this is kept open?

comment:6 Changed 4 years ago by casella

  • Resolution set to fixed
  • Status changed from new to closed

@dietmarw, since you are the reporter, if you are happy with the outcome you can close it yourself :)

comment:7 Changed 4 years ago by dietmarw

@casella It was you who rescheduled the ticket twice. How am I supposed to know that it was merged. The PR itself just receives cryptic Hudson messages that the test succeed but not that it was actually merged. So really the reporter needs a bit more transparency here.

Note: See TracTickets for help on using tickets.