Opened 7 years ago
Closed 6 years ago
#4735 closed defect (fixed)
Bad treatment of patches in OMCompiler repository
| Reported by: | rfranke | Owned by: | sjoelund.se |
|---|---|---|---|
| Priority: | high | Milestone: | 1.13.0 |
| Component: | Build Environment | Version: | |
| Keywords: | Cc: | sjoelund.se |
Description
The commit Fix wrong pointer type renames CevalScript.1.patch.xz to CevalScript.c.1.patch.xz.
When updating the sources and recompiling, the previous CevalScript.1.patch remains in the boot/patches directory and causes the compilation to fail.
Shouldn't at least make clean remove the old file?
Alternatively, couldn't the patches be in the git repository without .xz compression, enabling git to show differences between commits and take care about renaming automatically?
Change History (3)
comment:1 Changed 7 years ago by sjoelund.se
comment:2 Changed 7 years ago by rfranke
Honestly I have no glue about details of those xz-compressed files, patches and tarballs. Accordingly, it is unlikely that I would come up with a fix that matches your rationale -- as said, in mine these text files should simply not be xz-compressed to solve the issue.
comment:3 Changed 6 years ago by sjoelund.se
- Resolution set to fixed
- Status changed from new to closed
Fixed by having make clean actually clean the patches.
Yes, make clean should clean these things. Feel free to fix that with a PR. And I don't see much point in keeping the patches as text-files; the files they patch are xz-compressed as well, and it's generated code so you don't need to track changes because the next change is either that we get a new tarball and remove all patches, or we make a new patch, which doesn't affect the original patch-file.