Equations with Complex variables lost in NF

[casella]

The test cases in the ScalableTestSuite with complex numbers still fail. The smallest test case you can try out is ScalableTestSuite.Electrical.DistributionSystemAC.Verification.LinearControlledLoad (which lacks the experiment annotation, so it does not show up in the repors).

The model has 64 variable and equations. Checking with the NF reports only 57 equations. I flattened the model with the OF and NF and spotted at least one missing equation:

  linearControlledLoad.R.i.re = linearControlledLoad.R.p.i.re;

I guess the same problem takes place in the larger examples.

[mahge930]

The original problem was due to the way we were converting complex types to the old front-end DAE structure. That has been fixed in ​#2266.

In addition we were creating normal equations instead of complex equations where needed. For example record equality was converted to DAE scalar equality. We should scalarize such kind complex equalities. In the mean time the fix is to create a DAE.COMPLEX_EQUATION which is originally intended for handling cases where such scalarization was not possible (e.g. due to function calls on either side of equality). However for now that is what I have done. I will see if I can do a proper scalarization.

Now the next apparent problem is that complex connector elements are not expanded/scalarized. Plus there seems to be an issue which I currently don't understand with either - flow connection equations not handled correct - or - duplicate equations not removed. I will check more.

[casella]

Replying to mahge930:

In addition we were creating normal equations instead of complex equations where needed. For example record equality was converted to DAE scalar equality. We should scalarize such kind complex equalities. In the mean time the fix is to create a DAE.COMPLEX_EQUATION which is originally intended for handling cases where such scalarization was not possible (e.g. due to function calls on either side of equality). However for now that is what I have done. I will see if I can do a proper scalarization.

Would you mind opening a separate ticket on this topic, so we can keep track of it? It is probably related to #4354.

Now the next apparent problem is that complex connector elements are not expanded/scalarized. Plus there seems to be an issue which I currently don't understand with either - flow connection equations not handled correct - or - duplicate equations not removed. I will check more.

Maybe @perost can help you with that?

[casella]

I have opened #4828 with a much smaller test case on the remaining issues.