Opened 7 years ago

Closed 5 years ago

#4937 closed defect (fixed)

Horizontal lines half-cut when on the top side of the plotting rectangle

Reported by: massimo ceraolo Owned by: Adeel Asghar
Priority: high Milestone: 1.14.0
Component: OMEdit Version:
Keywords: Cc:

Description

See enclosed picture, obtained from a simple MSL ramp.
On my hi-res screen I chose 4 pixel width for plot curves.
The last horizontal segment is two (instead of four) pixel wide.

Just a minor glitch, but worth mentioning, I think.

Attachments (7)

2018-05-11 (4).png (62.4 KB ) - added by massimo ceraolo 7 years ago.
plotCut.Svg (56.4 KB ) - added by massimo ceraolo 6 years ago.
PlotCutShot.png (71.5 KB ) - added by massimo ceraolo 6 years ago.
RefSpeed.mo (447 bytes ) - added by massimo ceraolo 6 years ago.
refSpeed.png (4.0 KB ) - added by massimo ceraolo 6 years ago.
refSpeed.svg (110.0 KB ) - added by massimo ceraolo 6 years ago.
Comparison.pdf (71.3 KB ) - added by massimo ceraolo 5 years ago.

Download all attachments as: .zip

Change History (18)

by massimo ceraolo, 7 years ago

Attachment: 2018-05-11 (4).png added

comment:1 by massimo ceraolo, 6 years ago

I found another very telling case.
Compare the screenshot (PlotCutShot.png) with the svg created from the plot: plotCut.svg (the latter is correct, and very nice).

by massimo ceraolo, 6 years ago

Attachment: plotCut.Svg added

by massimo ceraolo, 6 years ago

Attachment: PlotCutShot.png added

comment:2 by massimo ceraolo, 6 years ago

I found a case that makes me change priority of this ticket. Consider the enclosed refSpeed.mo refSpeed.png, refSpeed.svg.
The png is VERY bad!

by massimo ceraolo, 6 years ago

Attachment: RefSpeed.mo added

by massimo ceraolo, 6 years ago

Attachment: refSpeed.png added

by massimo ceraolo, 6 years ago

Attachment: refSpeed.svg added

comment:3 by massimo ceraolo, 6 years ago

Priority: lowhigh

comment:4 by Francesco Casella, 6 years ago

Milestone: 1.13.01.14.0

Rescheduled to 1.14.0 after 1.13.0 releasee

comment:5 by massimo ceraolo, 5 years ago

Has anyone seen the plots in this ticket? I see it is still catalogued as new defect.
Especially refSpeed.png and refSpeed.svg are worth looking at.

comment:6 by Francesco Casella, 5 years ago

@ceraolo, I just opened #5515, which addresses a significant usability issue when dealing with PWM signals. I guess the solution proposed there would also fix this issue, what do you think?

comment:7 by massimo ceraolo, 5 years ago

Yes, adding some top and bottom margin should solve also this ticket's issue.

In addition, this ticket shows that PNG's are much worse than SVG's, not only because of the extrema values but also for the quality of text.

Once #5515 is solved maybe this #4937 can be closed and an additional one could be open to address PNG quality. It should be easy to improve PNG's since we have the corresponding SVG which is ok.

BTW, have you tried the quality of SVGs obtained from you PWM signals?

comment:8 by Francesco Casella, 5 years ago

Those PNGs are just raw screen captures to show what I see on screen.

in reply to:  8 comment:9 by massimo ceraolo, 5 years ago

Replying to casella:

Those PNGs are just raw screen captures to show what I see on screen.

Not quite so.
Look at Comparison.pdf.

by massimo ceraolo, 5 years ago

Attachment: Comparison.pdf added

comment:10 by Francesco Casella, 5 years ago

I see, sorry, I messed up with another ticket

@adeas31, why is the png export of worst quality than the rendering on the screen?

comment:11 by Adeel Asghar, 5 years ago

Resolution: fixed
Status: newclosed

The curves cutting issue is solved in #5515.
The PNG export quality is improved in 28e53ad/OpenModelica.

Note: See TracTickets for help on using tickets.