Javascript result files missing in newInst verification reports by Hudson

[Francesco Casella]

All test results contained in ​https://libraries.openmodelica.org/branches/newInst lack the javascript and csv files of wrong signals.

Please fix that ASAP.

[Francesco Casella]

Most likely due to variable/file names containing square brackets that are not escaped correctly.

[Francesco Casella]

Now all the test cases with some verification issues are reported as failing during simulation, even though the link under (sim) says the simulation ended successfully, see also #4997

[Adrian Pop]

That's my bad, I fixed the Python testing script (all tests were failing) but in one case it was some bad code. It should return to the previous behavior soon enough.

[Adrian Pop]

Strangely enough, diff files are generated for "master" branch but not for "newInst" branch.
That might imply some weird error when calling diffSimulationResults due to setting -d=newInst.

[Adrian Pop]

What is even more strange is that
ScalableTestSuite.Electrical.TransmissionLine.ScaledExperiments.TransmissionLineModelica_N_640
does not verify but
ScalableTestSuite.Electrical.TransmissionLine.ScaledExperiments.TransmissionLineModelica_N_1280
verifies fine :)

[Francesco Casella]

Replying to adrpo:

Strangely enough, diff files are generated for "master" branch but not for "newInst" branch.
That might imply some weird error when calling diffSimulationResults due to setting -d=newInst.

@perost, any idea?

[Adrian Pop]

I think the problem is that Martin used rsync --include-from=pattern-file which copies files that match the *patterns* in pattern-file. But if a file has a pattern like:

/files/ScalableTestSuite_noopt_ScalableTestSuite.Electrical.TransmissionLine.ScaledExperiments.TransmissionLineModelica_N_640.diff.transmissionline.L[5].v.csv
/files/ScalableTestSuite_noopt_ScalableTestSuite.Electrical.TransmissionLine.ScaledExperiments.TransmissionLineModelica_N_640.diff.transmissionline.L[5].v.html
/files/ScalableTestSuite_noopt_ScalableTestSuite.Electrical.TransmissionLine.ScaledExperiments.TransmissionLineModelica_N_640.diff.transmissionline.L[4].v.csv
/files/ScalableTestSuite_noopt_ScalableTestSuite.Electrical.TransmissionLine.ScaledExperiments.TransmissionLineModelica_N_640.diff.transmissionline.L[4].v.html
/files/ScalableTestSuite_noopt_ScalableTestSuite.Electrical.TransmissionLine.ScaledExperiments.TransmissionLineModelica_N_640.diff.transmissionline.L[3].v.csv
/files/ScalableTestSuite_noopt_ScalableTestSuite.Electrical.TransmissionLine.ScaledExperiments.TransmissionLineModelica_N_640.diff.transmissionline.L[3].v.html
/files/ScalableTestSuite_noopt_ScalableTestSuite.Electrical.TransmissionLine.ScaledExperiments.TransmissionLineModelica_N_640.diff.transmissionline.L[2].v.csv
/files/ScalableTestSuite_noopt_ScalableTestSuite.Electrical.TransmissionLine.ScaledExperiments.TransmissionLineModelica_N_640.diff.transmissionline.L[2].v.html
/files/ScalableTestSuite_noopt_ScalableTestSuite.Electrical.TransmissionLine.ScaledExperiments.TransmissionLineModelica_N_640.diff.transmissionline.C[5].p.i.csv
/files/ScalableTestSuite_noopt_ScalableTestSuite.Electrical.TransmissionLine.ScaledExperiments.TransmissionLineModelica_N_640.diff.transmissionline.C[5].p.i.html
/files/ScalableTestSuite_noopt_ScalableTestSuite.Electrical.TransmissionLine.ScaledExperiments.TransmissionLineModelica_N_640.diff.der(transmissionline.L[5].i).csv
/files/ScalableTestSuite_noopt_ScalableTestSuite.Electrical.TransmissionLine.ScaledExperiments.TransmissionLineModelica_N_640.diff.der(transmissionline.L[5].i).html
/files/ScalableTestSuite_noopt_ScalableTestSuite.Electrical.TransmissionLine.ScaledExperiments.TransmissionLineModelica_N_640.diff.der(transmissionline.L[4].i).csv
/files/ScalableTestSuite_noopt_ScalableTestSuite.Electrical.TransmissionLine.ScaledExperiments.TransmissionLineModelica_N_640.diff.der(transmissionline.L[4].i).html
/files/ScalableTestSuite_noopt_ScalableTestSuite.Electrical.TransmissionLine.ScaledExperiments.TransmissionLineModelica_N_640.diff.der(transmissionline.L[3].i).csv
/files/ScalableTestSuite_noopt_ScalableTestSuite.Electrical.TransmissionLine.ScaledExperiments.TransmissionLineModelica_N_640.diff.der(transmissionline.L[3].i).html
/files/ScalableTestSuite_noopt_ScalableTestSuite.Electrical.TransmissionLine.ScaledExperiments.TransmissionLineModelica_N_640.diff.der(transmissionline.L[2].i).csv
/files/ScalableTestSuite_noopt_ScalableTestSuite.Electrical.TransmissionLine.ScaledExperiments.TransmissionLineModelica_N_640.diff.der(transmissionline.L[2].i).html
/files/ScalableTestSuite_noopt_ScalableTestSuite.Electrical.TransmissionLine.ScaledExperiments.TransmissionLineModelica_N_640.diff.der(transmissionline.C[5].v).csv
/files/ScalableTestSuite_noopt_ScalableTestSuite.Electrical.TransmissionLine.ScaledExperiments.TransmissionLineModelica_N_640.diff.der(transmissionline.C[5].v).html
/files/ScalableTestSuite_noopt_ScalableTestSuite.Electrical.TransmissionLine.ScaledExperiments.TransmissionLineModelica_N_640.diff.der(transmissionline.C[4].v).csv
/files/ScalableTestSuite_noopt_ScalableTestSuite.Electrical.TransmissionLine.ScaledExperiments.TransmissionLineModelica_N_640.diff.der(transmissionline.C[4].v).html
/files/ScalableTestSuite_noopt_ScalableTestSuite.Electrical.TransmissionLine.ScaledExperiments.TransmissionLineModelica_N_640.diff.der(transmissionline.C[3].v).csv
/files/ScalableTestSuite_noopt_ScalableTestSuite.Electrical.TransmissionLine.ScaledExperiments.TransmissionLineModelica_N_640.diff.der(transmissionline.C[3].v).html
/files/ScalableTestSuite_noopt_ScalableTestSuite.Electrical.TransmissionLine.ScaledExperiments.TransmissionLineModelica_N_640.diff.der(transmissionline.C[2].v).csv
/files/ScalableTestSuite_noopt_ScalableTestSuite.Electrical.TransmissionLine.ScaledExperiments.TransmissionLineModelica_N_640.diff.der(transmissionline.C[2].v).html
/files/ScalableTestSuite_noopt_ScalableTestSuite.Electrical.TransmissionLine.ScaledExperiments.TransmissionLineModelica_N_640.diff.der(transmissionline.C[1].v).csv
/files/ScalableTestSuite_noopt_ScalableTestSuite.Electrical.TransmissionLine.ScaledExperiments.TransmissionLineModelica_N_640.diff.der(transmissionline.C[1].v).html

they will actually not match the files in question as the parentheses are interpreted differently in patterns.

I attempt a fix here
​https://github.com/OpenModelica/OpenModelicaLibraryTesting/commit/4c8ea0f87c9aa33fd7c3ce8768aadfa79a886c37
where I use different patterns and increase rsync verbosity so we see what is actually copied.

[Francesco Casella]

Let's see what happens with the next test run.

However, I'm not sure this is actually the problem. TransmissionLineModelica_N_640 has ​issues while TransmissionLineModelica_N_320 doesn't. It turns out, the missing variables in the 640 case are also found in the 320 case. So, I'm afraid the root cause is somewhere else, e.g. rsync timeout or something like that.

BTW, are all legal Modelica variable name also legal parts of a filenames in Windows, Linux and MacOS? Otherwise, besides escaping characters that have a "pattern" meaning (assuming it is necessary), we should also encode characters that are not allowed in filenames.

[Adrian Pop]

Yes, that is strange that larger or smaller variation of the same model verifies fine but the 640 one doesn't!

There should be no problem with filenames as the things not allowed in filenames are never present in Modelica variables (except maybe when we have quoted identifiers).
Anyhow we have error reporting if the files are not created. The only problem here is that we don't copy them to libraries. The test runs on ripper.openmodelica.org and at the end we copy stuff to libraries.openmodelica.org via rsync.

[Francesco Casella]

Let's see if a more verbose rsync will finally tell us what's happening

[Adrian Pop]

At least now we get the files where we should :)
​https://libraries.openmodelica.org/branches/newInst/ScalableTestSuite/files/ScalableTestSuite_ScalableTestSuite.Electrical.TransmissionLine.ScaledExperiments.TransmissionLineModelica_N_640.diff.transmissionline.L[5].v.html

[Francesco Casella]

Great, thanks! Now I can make some analysis