Opened 6 years ago
Closed 6 years ago
#5054 closed defect (fixed)
Remaining issue with rooted in NF
| Reported by: | Francesco Casella | Owned by: | Adrian Pop |
|---|---|---|---|
| Priority: | high | Milestone: | 2.0.0 |
| Component: | New Instantiation | Version: | |
| Keywords: | Cc: |
Description
After support fro overconstrained connectors was pushed in, there is a remaining issue in all the MultiBody models of the ScalableTestSuite, see, e.g. this one. The error reported is:
[OpenModelica/OMCompiler/Compiler/NFFrontEnd/NFCeval.mo:1440:9-1441:51:writable] Error: Internal error NFCeval.evalBuiltinCall: unimplemented case for rooted
These models all use plain vanilla components from MSL 3.2.2, where rooted was replaced by Connection.rooted. Is the error message misleading (thus there is an issue with Connection.rooted that needs to be fixed) or has the old, deprecated operator crept in somehow?
Attachments (1)
Change History (4)
comment:1 by , 6 years ago
by , 6 years ago
comment:2 by , 6 years ago
PR: https://github.com/OpenModelica/OMCompiler/pull/2586 adds a better check about the missing Connection.branch edge in the graph needed for Connection.rooted. It issues a warning and continues. The prefixing problems remains thou.
comment:3 by , 6 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Fix ticket with PR: https://github.com/OpenModelica/OMCompiler/pull/2591
Test ticket with PR: https://github.com/OpenModelica/OpenModelica-testsuite/pull/1007
Seems to be an issue with prefixing / subscripting, I get:
Connections.rooted(revolute.frame_a.R)when I should get:Connections.rooted(revolute[1].frame_a.R),Connections.rooted(revolute[2].frame_a.R).Because of this I cannot find the actual branch in the graph either
branch(revolute[1].frame_a.R, revolute[1].frame_b.R)orrevolute[2].frame_a.R, revolute[2].frame_b.R).I'll investigate why there is no proper prefixing for just this builtin operator.