Opened 6 years ago

Last modified 3 years ago

#5480 new defect

Automatic formatting does not respect indentation

Reported by: dariomangoni@… Owned by: Adeel Asghar
Priority: high Milestone:
Component: OMEdit Version: v1.14.0-dev-nightly
Keywords: indentation formatting Cc:

Description

Indentation is not respected when autoformatting.

https://imgur.com/a/Qn15AT7

Attachments (4)

indentation.mp4 (52.1 KB ) - added by dariomangoni@… 6 years ago.
indentation_problem
TestLibraryIndentation.zip (2.6 KB ) - added by dariomangoni@… 6 years ago.
miminalexample
indentation.2.mp4 (58.7 KB ) - added by anonymous 6 years ago.
IndentationOnMinimalExample
indentation.3.wmv (2.6 MB ) - added by Adeel Asghar 6 years ago.

Change History (15)

by dariomangoni@…, 6 years ago

Attachment: indentation.mp4 added

indentation_problem

comment:1 by Francesco Casella, 6 years ago

Milestone: Future1.14.0

comment:2 by Francesco Casella, 6 years ago

Most of these issues take place when using a single file for the entire package. If you save each class in a separate .mo file, there are less problems.

comment:3 by Adeel Asghar, 6 years ago

I tried to reproduce this without success. Can you share a test model?

by dariomangoni@…, 6 years ago

Attachment: TestLibraryIndentation.zip added

miminalexample

by anonymous, 6 years ago

Attachment: indentation.2.mp4 added

IndentationOnMinimalExample

comment:4 by dariomangoni@…, 6 years ago

Wow, man, I'm not a fantastic DEbugger, but I'm a fabolous BUGGER :-))))

After some struggling I got the infected pattern that gives troubles.
With just Library>Package>Model it doesn't give any issue.
The problem is with Library>Package>Package>Model

I just attached the miminal example and the recording of my screen.

by Adeel Asghar, 6 years ago

Attachment: indentation.3.wmv added

comment:5 by Adeel Asghar, 6 years ago

Well this also works fine for me.

Which operating system you are using? What does OMEdit About windows says?

comment:6 by dariomangoni@…, 6 years ago

Please consider that this issue has always been there since I started working with OpenModelica more than one year ago.

This is my current version, but it does not matter. It happens also with previous ones.

OMEdit - OpenModelica Connection Editor
OMEdit v1.14.0-dev-5914-g99eb5ee5a (64-bit)
Connected to v1.14.0-dev-265-g92a411947 (64-bit)
Connected to OMSimulator v2.1.0-dev-101-g89a8623-mingw

I have Windows 10 Home version 1803, build 17134.765.

comment:7 by Adeel Asghar, 6 years ago

Very strange. I have the same setup but unable to reproduce the issue.

comment:8 by Francesco Casella, 5 years ago

Milestone: 1.14.01.16.0

Releasing 1.14.0 which is stable and has many improvements w.r.t. 1.13.2. This issue is rescheduled to 1.16.0

comment:9 by Francesco Casella, 4 years ago

Milestone: 1.16.01.17.0

Retargeted to 1.17.0 after 1.16.0 release

comment:10 by Francesco Casella, 4 years ago

Milestone: 1.17.01.18.0

Retargeted to 1.18.0 because of 1.17.0 timed release.

comment:11 by Francesco Casella, 3 years ago

Milestone: 1.18.0

Ticket retargeted after milestone closed

Note: See TracTickets for help on using tickets.