Opened 6 years ago
Last modified 6 years ago
#5542 closed defect
OMC generates simulation code out of systems with invalid connections — at Initial Version
| Reported by: | Francesco Casella | Owned by: | Per Östlund |
|---|---|---|---|
| Priority: | blocker | Milestone: | 1.14.0 |
| Component: | New Instantiation | Version: | |
| Keywords: | Cc: | massimo ceraolo |
Description
Consider the attached test case, where an electrical pin is connected to a thermal port. OMC generates simulation code out of it and runs a simulation.
Besides the obvious question: what equations were actually put in the system and what does the corresponding simulation result mean, there is a more fundamental problem: this violates a basic rule in connections, see Sect. 9.1 of the specification, which reads
In a connect-equation the two connectors must have the same named component elements with the same dimensions; recursively down to the primitive components. The primitive components with the same name
are matched and belong to the same connection set.
This behaviour is obtained both from the OF and from the NF. I guess we should just care to fix it in the NF.
@perost, is this an easy fix or a complex one? It would be nice to get it in 1.14.0, but if we can't, feel free to move it to 2.0.0
