Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#5662 closed defect (fixed)

nfAPI does not locate a submodel

Reported by: massimo ceraolo Owned by: Adrian Pop
Priority: blocker Milestone: 1.16.1
Component: NF API Version:
Keywords: Cc:

Description

Consider the enclosed RedBoxIssue package.
If we open "MyModel" without nfAPI, we see one red box because of a missing model => correct.
If we open the same model with nfAPI (Selecting the box in OMEdit Options|Simulation "Enable new frontend use in OMC API) we see two red boxes, which is wrong.

Since this is a regression I mark this issue as a blocker for 1.14.0.

I did tests restarting OMEdit before opening the models, and using OMEdit Connected to OpenModelica v1.14.0-dev-26739-g57a0101ee7 (64-bit)

Attachments (1)

RedBoxIssue.mo (25.9 KB ) - added by massimo ceraolo 5 years ago.

Download all attachments as: .zip

Change History (16)

by massimo ceraolo, 5 years ago

Attachment: RedBoxIssue.mo added

comment:1 by Francesco Casella, 5 years ago

@adrpo please fix this if possible for 1.14.0-dev.beta3

Thanks!

comment:2 by Francesco Casella, 5 years ago

Milestone: 1.14.01.15.0

Rescheduled to 1.15.0 due to lack of time

in reply to:  2 comment:3 by massimo ceraolo, 5 years ago

Replying to casella:

Rescheduled to 1.15.0 due to lack of time

I suppose this is done in preparation for 1.14 release.
Will nfAPI be default then for 1.14 without fixing this ticket?

If this is the idea, I'm not sure it's a good idea. People will see red boxes appear where earlier there were model icons, and consequently previously working models failing.
According to my experience, it won't be a rare event.

comment:4 by Adrian Pop, 5 years ago

I will continue to look into this ticket, I have some ideas how to fix it but what I could try until now didn't work. If I can fix it soon we can make a 1.14.1 rather easily.

Last edited 5 years ago by Adrian Pop (previous) (diff)

comment:5 by Francesco Casella, 5 years ago

@ceraolo, the OSMC Board just took the decision to switch from feature-based release to time-based release, because otherwise our releases are always too rare and too late. So, we plan on two release whatever stable features we have two times per year, one in early winter, one in early summer. That's the model followed by most softwares, think Ubuntu or Dymola.

After almost one year we released 1.13.2, we can't postpone 1.14.0 further.

If there are critical issues and regressions, we can fix them in minor releases such as 1.14.1. Those will just contain the main release plus a few cherry-picked fixes, and replace the earlier releases. We already did that with 1.13.1 and 1.13.2, that fixed specific issues.

comment:6 by Francesco Casella, 5 years ago

Milestone: 1.15.01.14.1

comment:7 by massimo ceraolo, 5 years ago

Ok. I respect the osmc decision.

I'm not sure that ubuntu or dymola leave in their releases important known regressions.
In this case (if nfApi is default) we do.

comment:8 by massimo ceraolo, 5 years ago

Milestone: 1.14.11.14.2

comment:9 by Francesco Casella, 5 years ago

There will probably be no 1.14.2 but rather a 1.15.0, let's see what we can do in the next couple of weeks.

comment:10 by massimo ceraolo, 5 years ago

Ok.
Note that 1.4.2 is among the trac options.

comment:11 by Francesco Casella, 5 years ago

Sure. I'll reschedule them to 1.15.0 as soon as I'm sure 1.15.0 is bein rolled out anytime soon.

comment:12 by Francesco Casella, 5 years ago

Milestone: 1.14.21.16.0

@adrpo, any chance to fix this for 1.16.0?

comment:13 by Francesco Casella, 4 years ago

Milestone: 1.16.01.17.0

Retargeted to 1.17.0 after 1.16.0 release

comment:14 by massimo ceraolo, 4 years ago

Resolution: fixed
Status: newclosed

The issue is not present anymore.
Must have been solved between 1.16.0-dev-648 and 1.17.0-dev-141

comment:15 by Adrian Pop, 4 years ago

Milestone: 1.17.01.16.1

Add test so we don't break it again:
https://github.com/OpenModelica/OpenModelica/pull/584

Note: See TracTickets for help on using tickets.