#5698 closed defect (fixed)
Cpp FMI Export doesn't work with OpenModelica 1.14.0 under Windows
| Reported by: | Rüdiger Franke | Owned by: | Adeel Asghar |
|---|---|---|---|
| Priority: | blocker | Milestone: | 1.14.0 |
| Component: | Installation program | Version: | v1.14.0-dev.beta2 |
| Keywords: | Cc: | Niklas Worschech, Adrian Pop, Karim Adbdelhak, Andreas Heuermann |
Description
It seems that the installation path changed from
c:/OpenModelica
to
c:/Program Files (x86)/OpenModelica
This causes the Cpp runtime to fail due to whitespaces in path names, i.e. missing quotes in some files. Should such a change be introduced just before the release of version 1.14.0?
Change History (20)
comment:1 by , 5 years ago
| Cc: | added |
|---|
comment:4 by , 5 years ago
I expected this to come and bite us later down the line. Maybe is the FMU build with CPP runtime that fails.
I will add a Jenkins stage that will test compiling simulation/FMU for C and Cpp runtime with OpenModelica installed in a path with spaces on Windows so we don't mess this up again.
comment:5 by , 5 years ago
I have an installation from June where OpenModelica was still installed directly under c: Typically I ask unexperienced people to install a stable version, i.e. 1.13 at the moment. Yesterday someone happended to download and install the "Stable Development" version. The error occured during FMI export and clearly indicated that make commands got cluttered due to spaces in path names.
You must have had similar issues for the C runtime. Can't the same fixed be duplicated for the Cpp runtime?
comment:7 by , 5 years ago
comment:8 by , 5 years ago
Yes. I am trying to fix it but the makefile generated from cpp codegen is bit different.
follow-up: 15 comment:9 by , 5 years ago
Should work fine with 32b3d26/OpenModelica but I will confirm it once the nightly builds are available.
comment:10 by , 5 years ago
Great!
Thanks @rfranke for reporting before the release. Otherwise, we'd have released 1.14.1 with that bugfix.
follow-up: 14 comment:12 by , 5 years ago
Hello, I was just trying to install version 1.13.2 today for Windows 10. I've tried to do it as a single user, but got an error. Then I did the installation as admin. The installation was successful for the admin profile, but not for single users (nothing in the Start menu). I didn't see any "install for all user" option when doing the admin installation. I was anyway able to run, e.g., OMEdit from the single user profile (just opening the .exe file directly from the folder), though receving some environment variable error. Then I uninstalled everything (running uninstall.exe). My question: what do you suggest to install now? Should I just wait for 1.14.1? If so, when will this be available?
comment:13 by , 5 years ago
Hello, me again. In the meanwhile I've installed 1.13.2 under a folder where I have full access rights (i.e., C:\Users\<Username>\OpenModelica1.13.264bit instead of C:\OpenModelica1.13.264bit). No spaces in the path. Everything seems to work, no environmental variable errors.
comment:14 by , 5 years ago
Replying to anonymous:
My question: what do you suggest to install now?
The latest stable version, i.e. 1.14.0-dev.beta2, unless you specifically need the feature discussed here (Cpp FMI export), in which case you need to wait for 1.14.0-dev.beta3 or for the final 1.14.0 release. These will incorporate this bugix (see the target milestone of this ticket).
Should I just wait for 1.14.1?
No.
We'll only make 1.14.1 if other blocker issues pop up after the final release or 1.14.0
comment:15 by , 5 years ago
Replying to adeas31:
Should work fine with 32b3d26/OpenModelica but I will confirm it once the nightly builds are available.
As I understand, there won't be any nightly build. Nightlies are currently based on 1.16.0-dev. You need to wait for 1.14.0-dev.beta3
follow-up: 17 comment:16 by , 5 years ago
The fix is in the master, so it will be in the nighties after tonight, it can be tested and then cherry-picked to maintenance/v1.14 to be part of the upcoming beta3.
comment:17 by , 5 years ago
Replying to adrpo:
The fix is in the master, so it will be in the nighties after tonight, it can be tested and then cherry-picked to maintenance/v1.14 to be part of the upcoming beta3.
Sure, sorry, that was obvious...
comment:18 by , 5 years ago
| Summary: | OpenModelica 1.14.0 under Windows → Cpp FMI Export doesn't work with OpenModelica 1.14.0 under Windows |
|---|---|
| Version: | → v1.14.0-dev.beta2 |
@rfranke, as far as I understand this change was implemented 5 months ago, see #4504. I am not 100% sure if it was only implemented for the C runtime and then ported later to Cpp, or maybe only implemented for the C runtime, maype @adrpo can comment on this.
Have you tried any of the Windows nightly builds since then?
#4504 was marked as blocker for 1.14.0 because in many corporate and academic environments computing resources are centrally managed, and users are not allowed to install their own programs outside the Windows system directories. We have also made sure that it works also on installations with non-ASCII characters in their usernames, which happenes e.g. for Russian users using Cyrillic usernames. This fix was sure beneficial for a lot of end users.
I find it strange that nobody used the Cpp runtime since then and did not report it. @niklwors works with the Cpp runtime together with people in Bielefeld, but I guess they build the runtime themselves and maybe put it somewhere else. It may be that nobody ever tried out Windows installation with Cpp runtime since then.
In any case, we should definitely fix this for 1.14.0. Can you please provide a test case to reproduce the issue?
Thanks!