SimulationResult does not contain promised variables when simulation fails

[dariomangoni@…]

The simulate script function promises to output a record that is formatted as the following:

record SimulationResult
  String resultFile;
  String simulationOptions;
  String messages;
  Real timeFrontend;
  Real timeBackend;
  Real timeSimCode;
  Real timeTemplates;
  Real timeCompile;
  Real timeSimulation;
  Real timeTotal;
end SimulationResult;

However, some variables may be missing if simulation fails; then, querying such variables, makes scripts end prematurely.

[casella]

This is a serious issue, because it's hard to debug a model which fails if one cannot see the results. I'll mark it as a blocker for 2.0.0, maybe we can do something about it while we work on the debugger

[adrpo]

This should be an easy fix, we just need some try/catch blocks I think, but without looking at the code you never know.

[sjoelund.se]

Adrian, it's things like the times are missing. You don't even need to use try/catch blocks.
Our scripts check for empty filename and if so, skips checking other variables.

[sjoelund.se]

Do you have an example where this happens? I only find cases that work properly, even in OMNotebook which has a special implementation for simulation results.

[dariomangoni@…]

Sorry guys, I didn't save the models that was causing troubles and right now, after some months I cannot find a way to reproduce the issue...

[sjoelund.se]

Ah, I just found an example when thinking of one more thing:

loadString("model M
equation
  assert(time < 0.5, \"abc\");
end M;");getErrorString();
r:=simulate(M);getErrorString();
x := r.timeSimulation;

Only if the simulation itself fails, time for simulation and total time (only) are missing. If translation fails, all variables are there.

[sjoelund.se]

​https://github.com/OpenModelica/OpenModelica/pull/6696