Opened 4 years ago
Closed 4 years ago
#6007 closed defect (fixed)
Improve replaceable class input widget
| Reported by: | Francesco Casella | Owned by: | Adeel Asghar |
|---|---|---|---|
| Priority: | blocker | Milestone: | 1.16.0 |
| Component: | OMEdit | Version: | |
| Keywords: | Cc: | Adrian Pop |
Description
The replaceable class input widget should be improved.
Please open the ThermoPower.Test.GasComponents.TestGasPlenum test case and double-click e.g. on SourceP1. The parameter medium shows the replaceable Medium package. Now, the component is instantiated as:
Gas.SourcePressure SourceP1(redeclare Medium = Medium, ...);
However, this redeclaration doesn't show up in the Medium wigdet, which is empty.
Furthermore, if I type in manually the class name, this is not passed down to the redeclaration; in fact, it also removes the current declaration.
I guess this really needs to be fixed for the release.
Also, the Parameters windows is sized based on the length of the other input widgets, but not considering the lenght of the strings in the replaceable windows drop-down list. Hence, this is not wide enough to show the names of replaceable classe, which are clipped. The length of the items in this drop-down list should also be considered to determine the width of the parameter window.
Last, but not least, in the drop-down menu we should also show the comments of the classes that are compatible, not only their names.
@adeas31, I checked again and indeed you can resize the parameter window manually. It's not particularly user-friendly, but at least you get a chance to see the information. Maybe it would be nice to have a pop-up text string with the comment of the class if you stay with the mouse over a certain item of the drop-down menu for a while. Would that be doable?