Mac OMEdit fails to build

[Adam Dershowitz]

I have openmodelica-devel installed through Macports: 1.16.0~dev-443-g5ab5bb3_0. I have not been able to get any of the recent updates to build successfully.
The most recent log is attached.

[Francesco Casella]

@sjoelund.se, could you have a quick look?

Is this likely to be a configuration-specific issue with @dersh's computer, or something more general? Do you think most MacOS users will be able to run 1.16.0?

[Martin Sjölund]

This is OpenModelica 332aaeb OMEdit which is using OMSimulator 8995b12

:info:build OMS/OMSProxy.cpp:1416:29: error: use of undeclared identifier 'oms_getResultFile'; did you mean 'oms_setResultFile'?
:info:build   oms_status_enu_t status = oms_getResultFile(cref.toUtf8().constData(), pFilename, pBufferSize);
:info:build                             ^~~~~~~~~~~~~~~~~
:info:build                             oms_setResultFile

But it should be there. My thought is perhaps if you have an OMSimulator header somewhere in a path that has preference. Possibly OMEdit should set include paths so it is ensured to use our version when compiling.

[Adeel Asghar]

Yes OMEdit set the include path for it. It has to be read from $OPENMODELICAINSTALLAIONPATH/include

[Adam Dershowitz]

I'm not sure if you mean that I should set the path, or if a change should be made in the code to have this path set?
If you have any suggestions, I'm happy to try them.
I doubt that it is an issue on my computer because 1) it was working until a recent version. 2) This is a new computer with a new install of Macports and openmodelica. So, it should be pretty close to "stock"

[Adam Dershowitz]

I did just try another upgrade, and I'm seeing the same problem as I had been. I also did a search for OMSimulator.h and I only found the file in:
openmodelica-devel/work/openmodelica_1.16.0~dev-572-g712393a/OMSimulator/src/OMSimulatorLib/OMSimulator.h
openmodelica-devel/work/openmodelica_1.16.0~dev-572-g712393a/build/include/OMSimulator.h

So, they are part of the newest download and build attempt.

[Adam Dershowitz]

I found that the current installed version of OMEdit (1.16.0~dev-443-g5ab5bb3_0) had put a file into /opt/local/include/OMSimulator.h So, I temporarily renamed that file, and now it does build correctly.
So, it seems that the issue is that when building it was first searching the path that included the current version, instead of just the new files. That likely means that first removing the current version, then building the new version, would also have worked. But, it also means that an upgrade is not currently possible, only a fresh install. And, even if an upgrade does work, it would potentially mean that a mix of old and new files are used for the build (so it would depend on what specific changes had occurred in the files).
So, there is now a work around, but this bug is still present, so I don't think that it should yet be closed.

[Francesco Casella]

Retargeted to 1.17.0 after 1.16.0 release

[Francesco Casella]

Retargeted to 1.18.0 because of 1.17.0 timed release.

[Francesco Casella]

Ticket retargeted after milestone closed