Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#6060 closed defect (fixed)

OMEdit crashes when changing connector names

Reported by: massimo ceraolo Owned by: Adeel Asghar
Priority: blocker Milestone: 1.16.0
Component: OMEdit Version:
Keywords: Cc: Andrea Bartolini

Description (last modified by massimo ceraolo)

Steps to reproduce:
1) load Test.mo
2) open Test1
3) open MyFirstOrder, go into text mode, and manually change u into u0 (whole word, two instances)
4) go in diagram mode and save.
5) show Test1 diagram, and slightly move myFirstOrder to right: the connecting line between step and myFirstOrder remains partially drawn
6) click "del" on that partially drawn line to remove it: CRASH.

Tested with OMEdit Connected to OpenModelica v1.16.0-dev-541-gfd2d61b3de (64-bit)

Attachments (1)

Test.mo (1.8 KB ) - added by massimo ceraolo 4 years ago.

Download all attachments as: .zip

Change History (7)

by massimo ceraolo, 4 years ago

Attachment: Test.mo added

comment:1 by massimo ceraolo, 4 years ago

Description: modified (diff)

comment:2 by Francesco Casella, 4 years ago

Priority: criticalblocker

Thank you @ceraolo!

We'll try to get this fixed for 1.16.0, or possibly with a 1.16.1 relase in September.

comment:3 by Francesco Casella, 4 years ago

Milestone: 1.16.01.16.1
Summary: This crashes OMEditOMEdit crashes when changing connector names

comment:4 by Adeel Asghar, 4 years ago

Resolution: fixed
Status: newclosed

Fixed in c370c60/OpenModelica.
@ceraolo thanks for reporting this. There were so many crash reports related to this error and I was searching for a useful use case to reproduce and fix this crash.

Fix should be in the tomorrow's nightly build and I will also port it to 1.16 as well.

comment:5 by Adeel Asghar, 4 years ago

Milestone: 1.16.11.16.0

comment:6 by Francesco Casella, 4 years ago

Cc: Andrea Bartolini added

Excellent! Thanks @ceraolo for nailing down the right test case and to @adeas31 for the quick fix.

I guess @Andrea will also be happy, he also had this problem several times.

Fix should be in the tomorrow's nightly build and I will also port it to 1.16 as well.

There should be no need for that, the deal is that we will branch off 1.16.0-beta.01 from master when @adrpo's replaceable fixes are ready. So if the fix is on master, it will be in 1.16.0 automatically.

The current 1.16.0 maintenance branch was tagged one month ago to release the stable 1.16.0-dev.01 version, which we wanted to have to make sure people relying on the nightly wouldn't be bugged off if something went wrong in these last few weeks. We haven't entered the beta release phase yet (alas!).

Note: See TracTickets for help on using tickets.