#6116 closed defect (fixed)
NF includes input records in the variables count
Reported by: | Andrea.Bartolini | Owned by: | perost |
---|---|---|---|
Priority: | critical | Milestone: | 2.0.0 |
Component: | New Instantiation | Version: | v1.16.0-dev |
Keywords: | Cc: | casella |
Description
Consider the following package (also attached):
package TestInput record R1 Real x; Real y; end R1; model M1 input R1 rec1; Real z; equation z = time; end M1; end TestInput;
In the model M1 the record R1 id declared as input, so when I check the model M1 I expect to obtain a balanced model with 1 equation and 1 variable.
Instead of that, this is what I obtain:
Check of TestInput.M1 completed successfully. Class TestInput.M1 has 1 equation(s) and 3 variable(s). 1 of these are trivial equation(s).
so it seems that the NF includes in the variables count the two variables declared inside the record R1, also if that record is declared as input in the model M1.
OMEdit - OpenModelica Connection Editor
Connected to OpenModelica 1.16.0~dev-624-g08661c9
Sysop: linux Ubuntu 18.04
Attachments (1)
Change History (8)
Changed 4 years ago by Andrea.Bartolini
comment:1 Changed 4 years ago by perost
- Resolution set to fixed
- Status changed from new to closed
comment:2 follow-up: ↓ 3 Changed 4 years ago by Andrea.Bartolini
I updated my nightly build this morning but the fix seems to be not available yet...
OMEdit - OpenModelica Connection Editor
Connected to OpenModelica 1.16.0~dev-627-ge2dd3e1
comment:3 in reply to: ↑ 2 Changed 4 years ago by perost
- Resolution fixed deleted
- Status changed from closed to reopened
Replying to Andrea.Bartolini:
I updated my nightly build this morning but the fix seems to be not available yet...
OMEdit - OpenModelica Connection Editor
Connected to OpenModelica 1.16.0~dev-627-ge2dd3e1
My apologies, it seems I missed checking the result of checkModel and assumed it worked since the flat model now matches the old frontend. But it doesn't work with the old frontend either, so there's actually an issue with checkModel too.
comment:4 Changed 4 years ago by perost
The checkModel issue should now be fixed in 4617b2bd.
comment:5 Changed 4 years ago by casella
@Andrea, please check also on the real application as soon as the nightly is available and close the ticket if everything's ok.
comment:6 Changed 4 years ago by Andrea.Bartolini
- Resolution set to fixed
- Status changed from reopened to closed
Successfully tested on both example and real application.
comment:7 Changed 4 years ago by Andrea.Bartolini
Thanks Per!
Fixed in ea33c64.