Function returning record with array fails

[Francesco Casella]

Please consider this test model (also attached)

model TestFunctionRecordArray
  constant Integer c = 3;

  record R
    Real v;
    Real x[c];
  end R;

  function f
    input Real v;
    output R rout;
  algorithm
    rout.v := v;
    rout.x := {0.3, 0.4, 0.3};
  end f;

  Real x;
  R r;
equation
  x = time;
  r = f(x);
end TestFunctionRecordArray;

The model fails during compilation with

TestFunctionRecordArray_functions.c:33:3: error: 
use of undeclared identifier '_rout'
  _rout._x = _OMC_LIT0;
  ^

[Mahder Alemseged Gebremedhin]

This is what the generated code for the function looks:

DLLExport
modelica_real omc_TestFunctionRecordArray_f__eval1(threadData_t *threadData, modelica_real _v)
{
  modelica_real _rout_v;
  real_array _rout_x;
  _tailrecursive: OMC_LABEL_UNUSED
  // _rout_v has no default value.
  // _rout_x has no default value.
  _rout_v = _v;

  _rout._x = _OMC_LIT0;
  _return: OMC_LABEL_UNUSED
  return _rout_v;
}

The error message is for this assignment

_rout._x = _OMC_LIT0;

A few things to notice here. First the function name is different. It seems there was an attempt to evaluate the function as you can see from the new name it has got f__eval1 instead of just f. This is done by the backed ​here.

The output of the function is also changed from a record to just a real variable. Probably by the same code in the backend. I am not sure why this is done.

The body, however, seems to have been half-way fixed to match the changes. The assignment to the variable rout.v of the record is fixed to a simple variable rout_v to reflect that there is no record anymore. However the array assignment of rout.x has not been changed. My guess is that a missing case or similar matching failure.

Per is the last person who has modified the relevant part of the code. So hopefully he can find it easier. If not I will take a look later next week.

[Per Östlund]

Replying to mahge930:

Per is the last person who has modified the relevant part of the code. So hopefully he can find it easier.

Not really, I just made some changes to DAE.FUNCTION a while ago that just happened to touch that code. No one seems to have made any significant changes to EvaluateFunctions in the last 5-6 years.

[Francesco Casella]

Ticket retargeted after milestone closed