Timeline


and

2019-10-08:

20:12 Changeset in OpenModelica [48efb091]Added-citation-metadatamaintenance/v1.14maintenance/v1.15maintenance/v1.16maintenance/v1.17maintenance/v1.18maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by Adeel Asghar <adeel.asghar@…>
  • 1 edit in OMCompiler/Compiler/Template/CodegenFMU.tpl

Fix FMU export for Windows

Quote the OMHOME path so that cp doesn't complain about spaces.

19:59 Changeset in OpenModelica [9564849e]Added-citation-metadatamaintenance/v1.14maintenance/v1.15maintenance/v1.16maintenance/v1.17maintenance/v1.18maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by Adrian Pop <adrian.pop@…>
  • 1 edit in OMCompiler/Makefile.common

replace libzmq dep with cppzmq dep

18:02 Changeset in OpenModelica [af903b61] by Adeel Asghar <adeel.asghar@…>
  • 1 edit in OMCompiler/Compiler/Template/CodegenFMU.tpl

Fix FMU export for Windows

Quote the OMHOME path so that cp doesn't complain about spaces.

17:54 Changeset in OpenModelica [712214c]Added-citation-metadatamaintenance/v1.14maintenance/v1.15maintenance/v1.16maintenance/v1.17maintenance/v1.18maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by perost <perost86@…>
  • 2 edits in OMCompiler/Compiler

[NF] Fix smooth calls when evaluating actualStream.

17:18 Changeset in OpenModelica [6bd3e6b7] by Adrian Pop <adrian.pop@…>
  • 1 edit in OMCompiler/Makefile.common

replace libzmq dep with cppzmq dep

17:12 Changeset in OpenModelica [5ea5f66c] by Per Östlund <per.ostlund@…>
  • 2 edits in OMCompiler/Compiler

[NF] Fix smooth calls when evaluating actualStream.

15:48 Ticket #5641 (Icon generator does not render text on package correctly) closed by adeas31
fixed: It is now fixed in 11d76cb/OpenModelica.
15:42 Changeset in OpenModelica [11d76cb]Added-citation-metadatamaintenance/v1.14maintenance/v1.15maintenance/v1.16maintenance/v1.17maintenance/v1.18maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by Adeel Asghar <adeel.asghar@…>
  • 2 edits
    2 adds in /

Adpat to the new output of text annotation

Added a test for generate_icons.py

14:23 Changeset in OpenModelica [294d057]Added-citation-metadatamaintenance/v1.14maintenance/v1.15maintenance/v1.16maintenance/v1.17maintenance/v1.18maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by perost <perost86@…>
  • 2 edits in /

[NF] Only add smooth when need to actualStream.

  • Only add smooth when the flow direction is unknown when evaluating actualStream.
14:03 Changeset in OpenModelica [fa6b8e7]Added-citation-metadatamaintenance/v1.14maintenance/v1.15maintenance/v1.16maintenance/v1.17maintenance/v1.18maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by Adeel Asghar <adeel.asghar@…>
  • 7 edits in OMEdit/OMEdit/OMEditGUI

Breakpoint markers for models inside package

Calculate the line numbering from model line start instead of text block start

13:58 Changeset in OpenModelica [ec47ecc] by adeas31 <adeel.asghar@…>
  • 2 edits
    2 adds in /

Adpat to the new output of text annotation

Added a test for generate_icons.py

13:24 Changeset in OpenModelica [7e71296] by kabdelhak <karim.abdelhak@…>
  • 4 edits in OMCompiler/Compiler

[BE] update delay operator differentiation

13:21 Changeset in OpenModelica [1ea8048] by Per Östlund <per.ostlund@…>
  • 2 edits in /

[NF] Only add smooth when need to actualStream.

  • Only add smooth when the flow direction is unknown when evaluating actualStream.
11:52 Changeset in OpenModelica [be7c680]Added-citation-metadatamaintenance/v1.14maintenance/v1.15maintenance/v1.16maintenance/v1.17maintenance/v1.18maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by perost <perost86@…>
  • 1 edit in OMCompiler/Compiler/NFFrontEnd/NFConnectEquations.mo

[NF] Improve ConnectEquation.evaluateFlowDirection.

  • Simplify the min and max attribute expressions before evaluating the flow direction.
11:04 Changeset in OpenModelica [89be54d] by Per Östlund <per.ostlund@…>
  • 1 edit in OMCompiler/Compiler/NFFrontEnd/NFConnectEquations.mo

[NF] Improve ConnectEquation.evaluateFlowDirection.

  • Simplify the min and max attribute expressions before evaluating the flow direction.
09:48 Changeset in OpenModelica [8a4592b9] by AnHeuermann <andreas.heuermann@…>
  • 1 edit
    4 deletes in testsuite/simulation/modelica/tearing

Removed tearing testcase 17

  • The example is not solvable for time > 0. Test has nothing to do with tearing and is not "fixable"
09:48 Changeset in OpenModelica [6975c86] by AnHeuermann <andreas.heuermann@…>
  • 5 edits
    24 adds in /

[Backend] Minimal tearing

A new way to tear strong components. Minimal tearing can be used to tear
discrete variables from strong components. This is usefull for models where
tearingMethod=noTearing fails and omc-tearing is too slow.
Use debug flag tearingMethod=minimalTearing to enable minimalTearing.

  • Added minimalTearing to Tearing.mo
  • Added helper functions to BackendDAEUtil.mo
  • Added testcases for minimal tearing

Co-authored-by: rbulatow <rbulatow@…>
Co-authored-by: kabdelhak <karim.abdelhak@…>

09:44 Changeset in OpenModelica [83d0207e]Added-citation-metadatamaintenance/v1.14maintenance/v1.15maintenance/v1.16maintenance/v1.17maintenance/v1.18maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by Adeel Asghar <adeel.asghar@…>
  • 1 edit in OMEdit/OMEdit/OMEditGUI/OMEditGUI.pro

Skip the include headers warnings

This avoids the warnings e.g., from FMILibrary. However, this still shows the warnings of OMEdit.

09:41 Changeset in OpenModelica [36548ec] by Adeel Asghar <adeel.asghar@…>
  • 7 edits in OMEdit/OMEdit/OMEditGUI

Breakpoint markers for models inside package

Calculate the line numbering from model line start instead of text block start

03:52 Ticket #5653 (Improve moving through arrow keys) created by ceraolo
Moving diagram parts through arrow keys is often convenient with …

2019-10-06:

23:22 Ticket #5652 (NF fails to evaluate Integer in if expression) closed by casella
invalid: I confirm that the problem is resolved if using the latest nightly …
15:36 Changeset in OpenModelica [8730c27]Added-citation-metadatamaintenance/v1.14maintenance/v1.15maintenance/v1.16maintenance/v1.17maintenance/v1.18maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by Adrian Pop <adrian.pop@…>
  • 1 edit in OMCompiler/Makefile.common

removed dependency from cppruntime to cppzmq

15:36 Changeset in OpenModelica [e5a537d]Added-citation-metadatamaintenance/v1.14maintenance/v1.15maintenance/v1.16maintenance/v1.17maintenance/v1.18maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by Adrian Pop <adrian.pop@…>
  • 1 edit in OMCompiler/Makefile.common

readded dependency

15:36 Changeset in OpenModelica [34a08f5b]Added-citation-metadatamaintenance/v1.14maintenance/v1.15maintenance/v1.16maintenance/v1.17maintenance/v1.18maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by Adrian Pop <adrian.pop@…>
  • 2 edits in OMCompiler

Updated 3rdParty with new cppzmq library. Extended makefile.common for installing zmq config files to libzmq/build/ folder, for using find_package(zeromq) in cmake. Installing cppzqm file to cppzmq/build/

2019-10-04:

16:16 Ticket #5651 (Problem with findZeroCrossings) closed by casella
fixed: Works like a charm. I'm just curious, what exactly are "fake dummy …
13:34 Changeset in OpenModelica [440886d7] by niklwors <niklas.worschech@…>
  • 1 edit in OMCompiler/Makefile.common

removed dependency from cppruntime to cppzmq

12:39 Changeset in OpenModelica [bee85762] by niklwors <niklas.worschech@…>
  • 1 edit in OMCompiler/Makefile.common

readded dependency

10:22 Changeset in OpenModelica [56dc527a] by niklwors <niklas.worschech@…>
  • 2 edits in OMCompiler

Updated 3rdParty with new cppzmq library. Extended makefile.common for installing zmq config files to libzmq/build/ folder, for using find_package(zeromq) in cmake. Installing cppzqm file to cppzmq/build/

2019-10-03:

15:58 Changeset in OpenModelica [41c101f]Added-citation-metadatamaintenance/v1.14maintenance/v1.15maintenance/v1.16maintenance/v1.17maintenance/v1.18maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by Adeel Asghar <adeel.asghar@…>
  • 1 edit in OMEdit/OMEdit/OMEditGUI/Annotations/TextAnnotation.cpp

Appropriate extents for default text shape

15:15 Changeset in OpenModelica [ff624f6d] by Adeel Asghar <adeel.asghar@…>
  • 1 edit in OMEdit/OMEdit/OMEditGUI/Annotations/TextAnnotation.cpp

Appropriate extents for default text shape

13:02 Changeset in OpenModelica [fa729ab] by Robert Braun <robert.braun@…>
  • 1 edit in OMSimulator

Submodule update

11:32 Changeset in OpenModelica [da3cf7e] by Robert Braun <robert.braun@…>
  • 4 edits in /

Separate action for fetch interfaces with OMSimulator

11:02 Changeset in OpenModelica [d47c06e] by Robert Braun <robert.braun@…>
  • 6 edits in /

Fetch interface data for external TLM models

11:02 Changeset in OpenModelica [c67d8fd4] by Robert Braun <robert.braun@…>
  • 1 edit in OMEdit/OMEdit/OMEditGUI/OMS/ModelDialog.h

Browse button for external TLM start scripts

2019-10-02:

23:34 Ticket #5652 (NF fails to evaluate Integer in if expression) created by ulrich1a
The following model runs fine in OF but fails in NF: […] The error …
20:57 Changeset in OpenModelica [0218247f]Added-citation-metadatamaintenance/v1.14maintenance/v1.15maintenance/v1.16maintenance/v1.17maintenance/v1.18maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by Adrian Pop <adrian.pop@…>
  • 47 edits in /

[codegen] Improved handling of records and record arrays in the codegen.

  • Every record now gets
    • A dedicated "default" constructor function for allocating its members.
      • this is used when the variable is declared. It initializes members to their default values.
      • Note that this is different from default modelica record constructor. The modelica constructor is used explictly. The "default" one is used always on declaration.
    • A dedicated copy function for copying its members.
    • An array typedef to base_array.
    • A macro for creating an array of the record.
      • This uses the constructor function to create each element of the array.
      • This uses generic array function with the record size.
    • A macro for copying an array
      • This uses the copy function to copy each element of the array.
    • A macro getter to access elements of the array.
      • this uses the proper casting on the returned type.
  • We now keep bindings in TYPES_VARS in when creating a record declaration in SimCode structure. The bindings are used as default values by the "default" constructor.
  • Bindings of a derived record declaration are handled properly now.
    • If a record is a derived record with modifications, then bindings of the modifications are available in the declration scope.

record A = B(k=exp); A r; 'exp' needs to be passed to the constrcutor

=> A_construct(A* r, exp) {...; r->k = exp; ...}

This means a default constrcutor will need those bindings passed to it explictly
if it is to work correctly. Now every TYPES_VAR of a record has a boolean attribute
specifiying whether it is bound from outside or not.

  • When collecting used functions in the BACKEND we traverse bindings of record members.
    • Right now this is needed because some functions get inlined and are not used by the equation system even though the model has instances of the record (since we generate constructors now we need them to be visiable even if the record is never used in a function).
    • The proper way to fix this would be to check if a record is used in a function and only then generate a constrcutor. OR another option is to also traverse record member bindings when doing inlining of functions (which is not done right now.) This seemed to be the simplest and probably quickest way even though we sometimes may generate a function even though it is not really used (very rarely).
  • Fixed copying of records in the simulation context.
  • If a record is being copied to simulation vars we need special handling. This is because there is no structure to simvars. The variables are scattered. Therefore there is now a copy function that writes a given record to the corresponding element in the simvars arrays.

The generated function <RecName>_copy_to_vars(RecType* src, .../*simvars locations*/) is used to achive this.

  • Improved generation of component references in function context
    • We can now handle qualified crefs with subscripts anywhere in the cref.
    • This is done uniformly in functionContextCref template. Try to use this everywehre.
  • CONTEXT_FUNCTION now has a cref prefix
    • This is prepeneded to any cref generated in function context. This gives us some scope control. E.g. it is used in record constructor functions to make all local variable accesses prepended to a specific record name that is passed as input to the function.
  • Unknown size array handling.
    • Arrays of unknown size are arrays where at least one dimension is unknown.
    • If an unknown size array is declared with a default value, i.e. a binding,

then it has fixed dimension sizes equal to the binding.

  • However if the unknown size array is declared with out a binding then it

is considered flexible and can change sizes as needed.

  • The array representation in the runtime system ,i.e. base_array, now has a

new memeber .flexible to signify this.

  • Handle array expressions of records i.e. {c1,c2,..} properly
    • Array expressions of records are handled a bit more cleanly now.
    • Do not sort record member variables in the record declaration. This is just absurd.
  • instDims in SimCodeFunction.VARIABLE is now list<DAE.dimension> not list<DAE.Expression>. This Helps to normalize handling od dimension expressions.
    • We really need to normalize the handling of dimension and subscript
    • Plus dimension and subscript related functions are not exchangable.

Constructs are interpreted differntly as dimension compared to subscript
and vice versa.

  • template dimension() now takes context as input. This is needed.
  • Some more minor fixes.
    • Casting of call expressions which return records is handled explictly now.
    • Change handling of casts.
      • Casts to modelica_integer are disabled for now.
      • Casts to records with different number of members are disabled for now.
    • Remove PARALLE_FUNCTION_CONTEXT
      • Use a boolean value in FUNCTION_CONTEXT instead. Most of what we do for these contexts is very similar.
    • Fix and rename sortIntN to countingSort.
      • The function can now handle non-unique lists.
16:52 Changeset in OpenModelica [c3f10a53] by Mahder Gebremedhin <mahdual@…>
  • 47 edits in /

[codegen] Improved handling of records and record arrays in the codegen.

  • Every record now gets
    • A dedicated "default" constructor function for allocating its members.
      • this is used when the variable is declared. It initializes members to their default values.
      • Note that this is different from default modelica record constructor. The modelica constructor is used explictly. The "default" one is used always on declaration.
    • A dedicated copy function for copying its members.
    • An array typedef to base_array.
    • A macro for creating an array of the record.
      • This uses the constructor function to create each element of the array.
      • This uses generic array function with the record size.
    • A macro for copying an array
      • This uses the copy function to copy each element of the array.
    • A macro getter to access elements of the array.
      • this uses the proper casting on the returned type.
  • We now keep bindings in TYPES_VARS in when creating a record declaration in SimCode structure. The bindings are used as default values by the "default" constructor.
  • Bindings of a derived record declaration are handled properly now.
    • If a record is a derived record with modifications, then bindings of the modifications are available in the declration scope.

record A = B(k=exp); A r; 'exp' needs to be passed to the constrcutor

=> A_construct(A* r, exp) {...; r->k = exp; ...}

This means a default constrcutor will need those bindings passed to it explictly
if it is to work correctly. Now every TYPES_VAR of a record has a boolean attribute
specifiying whether it is bound from outside or not.

  • When collecting used functions in the BACKEND we traverse bindings of record members.
    • Right now this is needed because some functions get inlined and are not used by the equation system even though the model has instances of the record (since we generate constructors now we need them to be visiable even if the record is never used in a function).
    • The proper way to fix this would be to check if a record is used in a function and only then generate a constrcutor. OR another option is to also traverse record member bindings when doing inlining of functions (which is not done right now.) This seemed to be the simplest and probably quickest way even though we sometimes may generate a function even though it is not really used (very rarely).
  • Fixed copying of records in the simulation context.
  • If a record is being copied to simulation vars we need special handling. This is because there is no structure to simvars. The variables are scattered. Therefore there is now a copy function that writes a given record to the corresponding element in the simvars arrays.

The generated function <RecName>_copy_to_vars(RecType* src, .../*simvars locations*/) is used to achive this.

  • Improved generation of component references in function context
    • We can now handle qualified crefs with subscripts anywhere in the cref.
    • This is done uniformly in functionContextCref template. Try to use this everywehre.
  • CONTEXT_FUNCTION now has a cref prefix
    • This is prepeneded to any cref generated in function context. This gives us some scope control. E.g. it is used in record constructor functions to make all local variable accesses prepended to a specific record name that is passed as input to the function.
  • Unknown size array handling.
    • Arrays of unknown size are arrays where at least one dimension is unknown.
    • If an unknown size array is declared with a default value, i.e. a binding,

then it has fixed dimension sizes equal to the binding.

  • However if the unknown size array is declared with out a binding then it

is considered flexible and can change sizes as needed.

  • The array representation in the runtime system ,i.e. base_array, now has a

new memeber .flexible to signify this.

  • Handle array expressions of records i.e. {c1,c2,..} properly
    • Array expressions of records are handled a bit more cleanly now.
    • Do not sort record member variables in the record declaration. This is just absurd.
  • instDims in SimCodeFunction.VARIABLE is now list<DAE.dimension> not list<DAE.Expression>. This Helps to normalize handling od dimension expressions.
    • We really need to normalize the handling of dimension and subscript
    • Plus dimension and subscript related functions are not exchangable.

Constructs are interpreted differntly as dimension compared to subscript
and vice versa.

  • template dimension() now takes context as input. This is needed.
  • Some more minor fixes.
    • Casting of call expressions which return records is handled explictly now.
    • Change handling of casts.
      • Casts to modelica_integer are disabled for now.
      • Casts to records with different number of members are disabled for now.
    • Remove PARALLE_FUNCTION_CONTEXT
      • Use a boolean value in FUNCTION_CONTEXT instead. Most of what we do for these contexts is very similar.
    • Fix and rename sortIntN to countingSort.
      • The function can now handle non-unique lists.
15:52 Changeset in OpenModelica [4772e5fa]Added-citation-metadatamaintenance/v1.14maintenance/v1.15maintenance/v1.16maintenance/v1.17maintenance/v1.18maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by Adrian Pop <adrian.pop@…>
  • 1 edit in OMCompiler/Compiler/BackEnd/FindZeroCrossings.mo

[BE] fix zero crossing detection iterator

  • use dummy $$$ var instead of real 0.0 val
15:14 Ticket #5646 (Crash when importing SSP files with TLM systems) closed by adeas31
fixed: Fixed in 3b5fdf8/OpenModelica. Thanks for the debugging. …
15:13 Changeset in OpenModelica [3b5fdf8]Added-citation-metadatamaintenance/v1.14maintenance/v1.15maintenance/v1.16maintenance/v1.17maintenance/v1.18maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by Adeel Asghar <adeel.asghar@…>
  • 1 edit in OMEdit/OMEdit/OMEditGUI/Modeling/ModelWidgetContainer.cpp

ticket:5646 Disable call to GitCommands until its fully implemented.

14:57 Changeset in OpenModelica [16694cf] by kabdelhak <karim.abdelhak@…>
  • 1 edit in OMCompiler/Compiler/BackEnd/FindZeroCrossings.mo

[BE] fix zero crossing detection iterator

  • use dummy $$$ var instead of real 0.0 val
14:49 Changeset in OpenModelica [9eb0ead] by Adeel Asghar <adeel.asghar@…>
  • 1 edit in OMEdit/OMEdit/OMEditGUI/OMEditGUI.pro

Skip the include headers warnings

This avoids the warnings e.g., from FMILibrary. However, this still shows the warnings of OMEdit.

14:23 Changeset in OpenModelica [51b0825d] by Adeel Asghar <adeel.asghar@…>
  • 1 edit in OMEdit/OMEdit/OMEditGUI/Modeling/ModelWidgetContainer.cpp

ticket:5646 Disable call to GitCommands until its fully implemented.

13:57 Changeset in OpenModelica [1ba9373c]Added-citation-metadatamaintenance/v1.14maintenance/v1.15maintenance/v1.16maintenance/v1.17maintenance/v1.18maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by Adeel Asghar <adeel.asghar@…>
  • 66 edits in OMEdit/OMEdit/OMEditGUI

Get rid of warnings

13:56 Changeset in OpenModelica [990f175]Added-citation-metadatamaintenance/v1.14maintenance/v1.15maintenance/v1.16maintenance/v1.17maintenance/v1.18maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by Adeel Asghar <adeel.asghar@…>
  • 8 edits in OMEdit/OMEdit/OMEditGUI

Remove the array index braces only once

13:41 Changeset in OpenModelica [8543979] by Adeel Asghar <adeel.asghar@…>
  • 66 edits in OMEdit/OMEdit/OMEditGUI

Get rid of warnings

13:21 Ticket #5651 (Problem with findZeroCrossings) created by casella
Please consider the following test model […] The expected solution …
09:13 Ticket #5650 (OMEdit does not update the cache) created by Andrea.Bartolini
Working with complex model structure, especially when more tabs are …

2019-10-01:

19:20 Ticket #5649 (Summary of issues with diffModelicaListings) created by casella
There are some remaining issues with diffModelicaListings which cause …
18:09 Changeset in OpenModelica [f42a582f]Added-citation-metadatamaintenance/v1.14maintenance/v1.15maintenance/v1.16maintenance/v1.17maintenance/v1.18maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by Adrian Pop <adrian.pop@…>
  • 2 edits in /

update libs

16:15 Changeset in OpenModelica [ecb37429] by Adrian Pop <adrian.pop@…>
  • 2 edits in /

update libs

12:39 Changeset in OpenModelica [6e847588] by Adeel Asghar <adeel.asghar@…>
  • 8 edits in OMEdit/OMEdit/OMEditGUI

Remove the array index braces only once

Note: See TracTimeline for information about the timeline view.