Context Navigation

We used to throw away any extra expressions and variable declarations needed for it, i.e., if it has some complicated subscript that can not be generated inline.

If you are sure you have a path (a cref with no subs) then you can use contextCrefNoPrevExp (e.g variable names are just paths. They are just represented as cref). Otherwise contextCref now needs a preEx and varDecls buffer passed to it.

Fix wrong ordering of buffer arguments.

Avoid unnecessary code generation.

This fixes ticket:5994.

The path we took for crefs with subscripts in function context used to create unnecessary temporaries and exps which we did not notice because they were were thrown away after being created.

Split up the function to take different paths for normal and parallel functions.

Add a test case for Ticket:5994.

13:11 Changeset in OpenModelica [85508bb]Added-citation-metadatamaintenance/v1.17maintenance/v1.18maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by Martin Sjölund <martin+github@…>

1 edit in OMCompiler/Compiler/NFFrontEnd/NFStatement.mo

[Flat] Use loop keyword for while loops

11:45 Changeset in OpenModelica [2c23e69]Added-citation-metadatamaintenance/v1.17maintenance/v1.18maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by Adeel Asghar <adeel.asghar@…>

2 edits in /

Add Cvode Documentation

Also fixed wrong order in tooltip

11:33 Changeset in OpenModelica [e9cca5c] by Martin Sjölund <martin.sjolund@…>

1 edit in OMCompiler/Compiler/NFFrontEnd/NFStatement.mo

[Flat] Use loop keyword for while loops

10:56 Changeset in OpenModelica [b93569f7] by Mahder Gebremedhin <mahder.gebremedhin@…>

1 edit
2 adds in testsuite/simulation/modelica/arrays

Add a test case for Ticket:5994.

10:51 Changeset in OpenModelica [d86f542] by AnHeuermann <andreas.heuermann@…>

2 edits in /

Add Cvode Documentation

Also fixed wrong order in tooltip

10:03 Changeset in OpenModelica [83ecc42]Added-citation-metadatamaintenance/v1.17maintenance/v1.18maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by Martin Sjölund <martin+github@…>

2 edits in OMCompiler/Compiler/NFFrontEnd

[Flat] Use toFlatString also on clock constructors

09:12 Changeset in OpenModelica [6586704] by Martin Sjölund <martin.sjolund@…>

1 edit in Jenkinsfile

[Jenkins] Use label in sh step

08:56 Changeset in OpenModelica [f076f681] by Martin Sjölund <martin.sjolund@…>

2 edits in OMCompiler/Compiler/NFFrontEnd

[Flat] Use toFlatString also on clock constructors

08:41 Ticket #5996 (Graphical support to propagate parameters) created by robert.hallqvist@…

Graphical support to propagate model parameters to a higher level of …

08:32 Ticket #5995 (FMU Export with Modelica.Utilities.Streams functions) created by robert.hallqvist@…

The following error is communicated when exporting a model …

07:39 Changeset in OpenModelica [f2d3941] by Martin Sjölund <martin.sjolund@…>

1 edit in Jenkinsfile

Use the MacOS path to OMEdit

2020-06-02:

23:51 Ticket #5927 (Viewing State Variables of Linearised Model) reopened by casella

Unfortunately it doesn't still work well. If I set the language to …

22:09 Changeset in OpenModelica [cad1972e]Added-citation-metadatamaintenance/v1.17maintenance/v1.18maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by Adrian Pop <adrian.pop@…>

8 edits in /

MinGW & other minor fixes

more homogenous handling of LINK_SUNDIALS_STATIC for ida_solver, cvode_solver and radau
signal that we link with static fmilib in FMICommon.h (define FMILIB_STATIC_LIB_ONLY)
more debugging in testsuite/simulation/libraries/common/ModelTesting.mos
change Util.absoluteOrRelative to check for the relative path and if it doesn't exist return the original path to generate better error messages

20:19 Changeset in OpenModelica [f3d05b9] by Adrian Pop <adrian.pop@…>

8 edits in /

MinGW & other minor fixes

more homogenous handling of LINK_SUNDIALS_STATIC for ida_solver, cvode_solver and radau
signal that we link with static fmilib in FMICommon.h (define FMILIB_STATIC_LIB_ONLY)
more debugging in testsuite/simulation/libraries/common/ModelTesting.mos
change Util.absoluteOrRelative to check for the relative path and if it doesn't exist return the original path to generate better error messages

19:30 Changeset in OpenModelica [38c76307]Added-citation-metadatamaintenance/v1.17maintenance/v1.18maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by hudson <openmodelica@…>

1 edit in libraries

Updated libraries

libraries c3edc70...06f38e4 (1):

Bump libraries

17:26 Changeset in OpenModelica [9837fec]Added-citation-metadatamaintenance/v1.17maintenance/v1.18maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by perost <perost86@…>

2 edits in OMCompiler/Compiler/NFFrontEnd

[NF] Fix subscripting of boxed/unboxed expressions.

Handle boxed types in Type.subscript.
Add assertion in Type.subscript to catch unhandled types.
Add special rules for unboxed/boxed values in Expression.applySubscript that subscripts the expressions they contain instead of creating unnecessary SUBSCRIPTED_EXPs.

16:55 Ticket #5927 (Viewing State Variables of Linearised Model) closed by Karim.Abdelhak

fixed: This should be fixed. If anything is not as expected, please reopen …

16:42 Changeset in OpenModelica [1d9a5831]Added-citation-metadatamaintenance/v1.17maintenance/v1.18maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by Adrian Pop <adrian.pop@…>

11 edits in /

[BE] jacobians: make residual names unique

make jacobian residual variables unique and use the name
avoids discarding them while differentiating in the case of nested jacobians

16:27 Changeset in BioChem [1dcaade]develop by Atiyah Elsheikh <a.m.g.elsheikh@…>

in /

Merge branch 'develop' of https://github.com/AtiyahElsheikh/BioChem into develop

16:17 Changeset in OpenModelica [6dbae204] by Per Östlund <perost86@…>

2 edits in OMCompiler/Compiler/NFFrontEnd

[NF] Fix subscripting of boxed/unboxed expressions.

Handle boxed types in Type.subscript.
Add assertion in Type.subscript to catch unhandled types.
Add special rules for unboxed/boxed values in Expression.applySubscript that subscripts the expressions they contain instead of creating unnecessary SUBSCRIPTED_EXPs.

16:15 Changeset in OpenModelica [4060689]Added-citation-metadatamaintenance/v1.17maintenance/v1.18maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by perost <perost86@…>

1 edit in OMCompiler/Compiler/NFFrontEnd/NFFlatten.mo

[NF] Clean up Flatten.

Pass the scalarize flag as a bool where it's needed instead of looking up the value of the flag over and over.
Split the array vectorization off to a separate function to make the code cleaner and avoid having to check whether to run the code for every array element.
Simplify binding handling in Flatten.flattenClass.

15:46 Changeset in OpenModelica [6f042252] by Mahder Gebremedhin <mahder.gebremedhin@…>

1 edit in OMCompiler/Compiler/Template/CodegenCFunctions.tpl

Avoid unnecessary code generation.

This fixes ticket:5994.

The path we took for crefs with subscripts in function context used to create unnecessary temporaries and exps which we did not notice because they were were thrown away after being created.

Split up the function to take different paths for normal and parallel functions.

15:42 Changeset in OpenModelica [4ab6c98] by AnHeuermann <andreas.heuermann@…>

1 edit in Jenkinsfile

Disable sanity check for Cpp runtime for the moment

OMCppOSUSimulation is throwwing an error when displaying help

15:29 Changeset in OpenModelica [ace816d2] by Mahder Gebremedhin <mahder.gebremedhin@…>

1 edit in OMCompiler/Compiler/Template/CodegenCFunctions.tpl

Fix wrong ordering of buffer arguments.

15:29 Changeset in OpenModelica [c0dad8f] by Karim Abdelhak <karim.abdelhak@…>

11 edits in /

[BE] jacobians: make residual names unique

make jacobian residual variables unique and use the name
avoids discarding them while differentiating in the case of nested jacobians

15:12 Changeset in OpenModelica [e8e79c25] by Per Östlund <perost86@…>

1 edit in OMCompiler/Compiler/NFFrontEnd/NFFlatten.mo

[NF] Clean up Flatten.

Pass the scalarize flag as a bool where it's needed instead of looking up the value of the flag over and over.
Split the array vectorization off to a separate function to make the code cleaner and avoid having to check whether to run the code for every array element.
Simplify binding handling in Flatten.flattenClass.

14:40 Changeset in OpenModelica [8db10e2] by Martin Sjölund <martin.sjolund@…>

1 edit in Jenkinsfile

Add sanity check for OMEdit and OMSI

14:09 Changeset in OpenModelica [42e2e6f3]Added-citation-metadatamaintenance/v1.17maintenance/v1.18maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by perost <perost86@…>

3 edits in OMCompiler/Compiler/NFFrontEnd

[NF] Retype conditional array expressions.

When doing branch selection on if-expressions where the branches have different dimensions, also do branch selection on the type of the if-expression.

13:48 Changeset in OpenModelica [6ad7c9b] by AnHeuermann <andreas.heuermann@…>

1 edit in OMCompiler/Makefile.omsi.common

[OSX] Fix dylib IDs for Cpp

Some install_name_tool magic for OMSICPPinstall target.

13:17 Changeset in OpenModelica [0de8347] by Mahder Gebremedhin <mahder.gebremedhin@…>

2 edits in OMCompiler/Compiler/Template

Handle preExp and varDecls for crefs with subs.

We used to throw away any extra expressions and variable declarations needed for it, i.e., if it has some complicated subscript that can not be generated inline.

If you are sure you have a path (a cref with no subs) then you can use contextCrefNoPrevExp (e.g variable names are just paths. They are just represented as cref). Otherwise contextCref now needs a preEx and varDecls buffer passed to it.

13:02 Changeset in OpenModelica [ff522fa5] by Per Östlund <perost86@…>

3 edits in OMCompiler/Compiler/NFFrontEnd

[NF] Retype conditional array expressions.

When doing branch selection on if-expressions where the branches have different dimensions, also do branch selection on the type of the if-expression.

11:52 Changeset in OpenModelica [e7596bc5] by AnHeuermann <andreas.heuermann@…>

2 edits in OMCompiler

[OSX] Fix dylib IDs

Fix wrong install_name_tool -id
Change rpath for cvode in libFmiRuntime.dylib

11:15 Changeset in OpenModelica [68b921e1] by AnHeuermann <andreas.heuermann@…>

1 edit in Jenkinsfile

[OSX] Check dylib and binaries for relative paths

11:06 Changeset in OpenModelica [7e121ae2] by AnHeuermann <andreas.heuermann@…>

1 edit in OMCompiler/Makefile.omsi.common

[OSX] Fix dylib IDs for Cpp

Some install_name_tool magic for OMSICPPinstall target.

00:38 Ticket #5994 (Invalid code generation when accessing array index with size(array,1)) created by a.d.e.suisse@…

Hello everybody When accessing an array index inside a function by …

2020-06-01:

19:41 Changeset in OpenModelica [cf4aa255] by AnHeuermann <andreas.heuermann@…>

2 edits in OMCompiler

[OSX] Fix dylib IDs

Fix wrong install_name_tool -id
Change rpath for cvode in libFmiRuntime.dylib

19:32 Changeset in OpenModelica [e8634fb]Added-citation-metadatamaintenance/v1.17maintenance/v1.18maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by hudson <openmodelica@…>

1 edit in libraries

Updated libraries

libraries 7e73535...c3edc70 (1):

Bump libraries

19:29 Changeset in OpenModelica [9f75cf9]Added-citation-metadatamaintenance/v1.17maintenance/v1.18maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by Adrian Pop <adrian.pop@…>

1 edit in OMCompiler/SimulationRuntime/c/simulation/solver/cvode_solver.h

link sundials statically on mingw in cvode_solver.h

19:26 Changeset in OpenModelica [05df6d2]Added-citation-metadatamaintenance/v1.17maintenance/v1.18maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by perost <perost86@…>

3 edits in /

[NF] Improve structural parameter handling.

When marking a size expression as structural, don't mark the expression in it since only the size of the expression is needed.

17:37 Changeset in OpenModelica [1d44648f] by Andreas Heuermann <andreas.heuermann@…>

2 edits in OMCompiler/SimulationRuntime/c/simulation/solver

[C-runtime] Fix static mingw build with CVODE

Use LINK_SUNDIALS_STATIC vor CVODE on mingw

17:27 Changeset in OpenModelica [21ddcac] by Per Östlund <perost86@…>

3 edits in /

[NF] Improve structural parameter handling.

When marking a size expression as structural, don't mark the expression in it since only the size of the expression is needed.

17:24 Changeset in OpenModelica [5e6ccaf4]Added-citation-metadatamaintenance/v1.17maintenance/v1.18maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by perost <perost86@…>

6 edits
1 add in OMCompiler/Compiler

[NF] Improve/cleanup expression traversal functions.

Implemented Expression.applyShallow.
Moved some traversal utility functions to the modules for the types they traverse, i.e. ComponentRef, Call, etc.
Moved Expression.ClockKind and its functions to a separate file.
Fixed apply for typed reductions, which would only apply the function to the default and fold expressions without traversing into them.

17:17 Changeset in OpenModelica [df3b568d] by Adrian Pop <adrian.pop@…>

1 edit in OMCompiler/SimulationRuntime/c/simulation/solver/cvode_solver.h

link sundials statically on mingw in cvode_solver.h

16:21 Changeset in OpenModelica [9f363b61] by Per Östlund <perost86@…>

6 edits
1 add in OMCompiler/Compiler

[NF] Improve/cleanup expression traversal functions.

Implemented Expression.applyShallow.
Moved some traversal utility functions to the modules for the types they traverse, i.e. ComponentRef, Call, etc.
Moved Expression.ClockKind and its functions to a separate file.
Fixed apply for typed reductions, which would only apply the function to the default and fold expressions without traversing into them.

14:50 Changeset in OpenModelica [4dd8916]Added-citation-metadatamaintenance/v1.17maintenance/v1.18maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by hudson <openmodelica@…>

1 edit in libraries

Updated libraries

libraries b1581bc...7e73535 (1):

update MEV to v1.0.1

14:36 Changeset in OpenModelica [984d1e2]Added-citation-metadatamaintenance/v1.17maintenance/v1.18maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by Martin Sjölund <martin+github@…>

1 edit in OMCompiler/Compiler/FrontEnd/ClassLoader.mo

Correct installPackage name in help text

14:32 Changeset in OpenModelica [dca21bb9] by Martin Sjölund <martin.sjolund@…>

1 edit in Jenkinsfile

[OSX] Check dylib and binaries for relative paths

13:55 Changeset in OpenModelica [081dc246] by Martin Sjölund <martin.sjolund@…>

1 edit in OMCompiler/Compiler/FrontEnd/ClassLoader.mo

Correct installPackage name in help text

13:24 Ticket #5992 (Singelton uniontypes containing non-singelton uniontypes are not ...) closed by johti17

fixed: Adjusted in: …

13:22 Changeset in OpenModelica [6d60ea0]Added-citation-metadatamaintenance/v1.17maintenance/v1.18maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by GitHub <noreply@…>

2 edits
2 adds in /

Singelton ut containing non singelton ut are treated as singeltons (#914)

Singelton ut containing non singelton ut are treated as singeltons

13:12 Ticket #5993 (error messages after installation of OM1.15 64bit in W10) closed by sjoelund.se

wontfix: Note that ModelicaAdditions is almost 19 years old. You need to use …

12:26 Changeset in OpenModelica [67e83e6b] by johti <johti17@…>

1 edit in OMCompiler/Compiler/FrontEnd/InstMeta.mo

Check suffix instead of stringcomp

2020-05-31:

16:35 Changeset in OpenModelica [458529be] by johti <johti17@…>

2 edits
2 adds in /

Singelton ut containing non singelton ut are treated as singeltons

2020-05-30:

18:26 Ticket #5993 (error messages after installation of OM1.15 64bit in W10) created by Micha109GE

I get two error message when I start OMedit: [1] 17:51:52 Grammatik …

08:54 Changeset in OpenModelica [c007a39]Added-citation-metadatamaintenance/v1.16maintenance/v1.17maintenance/v1.18maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by perost <perost86@…>

2 edits in OMCompiler/Compiler/NFFrontEnd

[NF] Subscripting fixes.

Fix type when subscripting enumerations.
Only remove subscripts if all of them simplify to :.

01:46 Changeset in OpenModelica [abb9682c] by Per Östlund <perost86@…>

2 edits in OMCompiler/Compiler/NFFrontEnd

[NF] Subscripting fixes.

Fix type when subscripting enumerations.
Only remove subscripts if all of them simplify to :.

2020-05-29:

18:57 Changeset in OpenModelica [f0d79210]Added-citation-metadatamaintenance/v1.16maintenance/v1.17maintenance/v1.18maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by hudson <openmodelica@…>

1 edit in libraries

Updated libraries

libraries 712bdb9...b1581bc (2):

Bump libraries
Buildings 7.0.0

17:44 Ticket #5992 (Singelton uniontypes containing non-singelton uniontypes are not ...) created by johti17

Singelton uniontypes containing a non singleton uniontype is not …

16:41 Changeset in OpenModelica [419f112]Added-citation-metadatamaintenance/v1.16maintenance/v1.17maintenance/v1.18maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by Lennart Ochel <lennart.ochel@…>

10 edits
5 adds in /

[C-runtime] Adding CVODE

For trac ticket 5830.

Adding Sundials CVODE v2.8.2 as integration method for C runtime. Use method="cvode" in OMEdit or -s=cvode when running the executable.
Possible to choose integrator method:
- For stiff problems [default]: -cvodeLinearMultistepMethod=CV_BDF -cvodeNonlinearSolverIteration=CV_NEWTON.
- For non-stiff problems: -cvodeLinearMultistepMethod=CV_ADAMS -cvodeNonlinearSolverIteration=CV_FUNCTIONAL.
Added tests for CVODE to testsuite.
- problem2 still failing

Additional changes to existing files:

Added check in printSparseStructure to check for NULL.
Fixed warnings during compilation of some infoStreamPrint calls.
Added new flags to choose CVODE solver and set some settings.
Changed debug print in ida_solver.c to use LOG_SOLVER_V instead of LOG_DASSL_STATES.
Added CVODE to solver_main.c.
Addapted build system to add libsundials_cvodes.* to runtime.

Still WIP:

Use colored dense numberic Jacobian instead of internal dense Jacobian from CVODE

15:05 Changeset in OpenModelica [03832ba] by AnHeuermann <andreas.heuermann@…>

10 edits
5 adds in /

[C-runtime] Adding CVODE

For trac ticket 5830.

Adding Sundials CVODE v2.8.2 as integration method for C runtime. Use method="cvode" in OMEdit or -s=cvode when running the executable.
Possible to choose integrator method:
- For stiff problems [default]: -cvodeLinearMultistepMethod=CV_BDF -cvodeNonlinearSolverIteration=CV_NEWTON.
- For non-stiff problems: -cvodeLinearMultistepMethod=CV_ADAMS -cvodeNonlinearSolverIteration=CV_FUNCTIONAL.
Added tests for CVODE to testsuite.
- problem2 still failing

Additional changes to existing files:

Added check in printSparseStructure to check for NULL.
Fixed warnings during compilation of some infoStreamPrint calls.
Added new flags to choose CVODE solver and set some settings.
Changed debug print in ida_solver.c to use LOG_SOLVER_V instead of LOG_DASSL_STATES.
Added CVODE to solver_main.c.
Addapted build system to add libsundials_cvodes.* to runtime.

Still WIP:

Use colored dense numberic Jacobian instead of internal dense Jacobian from CVODE

14:10 Changeset in OpenModelica [e293f5a]Added-citation-metadatamaintenance/v1.16maintenance/v1.17maintenance/v1.18maintenance/v1.19maintenance/v1.20maintenance/v1.21maintenance/v1.22maintenance/v1.23omlib-staging by perost <perost86@…>

12 edits in OMCompiler/Compiler/NFFrontEnd

[NF] Flat Modelica improvements.

Simplify away subscripts when devectorizing calls if possible.
Recheck whether a subscript is a slice or not after modifying the contained expression via e.g. Subscript.map.
Only dump 'input' prefix for top-level components.
Dump type attributes for components in e.g. functions.
Dump 'public' for public elements, otherwise everything will be private after the first private element.
Fix dumping of array dimensions which was using normal toString.
Change more dump functions to use IOStream.

13:19 Changeset in OpenModelica [cb30381] by Per Östlund <perost86@…>

12 edits in OMCompiler/Compiler/NFFrontEnd

[NF] Flat Modelica improvements.

Simplify away subscripts when devectorizing calls if possible.
Recheck whether a subscript is a slice or not after modifying the contained expression via e.g. Subscript.map.
Only dump 'input' prefix for top-level components.
Dump type attributes for components in e.g. functions.
Dump 'public' for public elements, otherwise everything will be private after the first private element.
Fix dumping of array dimensions which was using normal toString.
Change more dump functions to use IOStream.