Probelm with handling "when statement" in an FMU

[uzahsan@…]

There has been a problem with models involving "when statements". The modelica code of these models work fine but the problem manifests itself once the model is exported as an FMU and then re-imported for simulation.
Running simulations after re-importing the FMU show that when conditions in the model never get fired at all.

[adeas31]

I have attached a test case.

[wbraun]

The fmi-export doesn't work well at all i.e. testsuite/openmodelica/fmi/ModelExchange/testInOutTest.mos is totally wrong. We can't use the ringbuffer for the exported model, since we can't assure the correct handling by the calling programs.

But the issue here is mostly fmi-import, since the function fmiEventUpdate needs a call every time a discrete variable is changing.
Further there are serious problem, with the compile-time and simulation-time with our fmi-import.

[wbraun]

in r20190 fixed some fmi export issues e.g. testsuite/openmodelica/fmi/ModelExchange/testInOutTest.mos works correctly again.

[wbraun]

Some of the performance issue are owed by ticket #2669.

[sjoelund.se]

This ticket was not closed for 1.9.1, which has now been released. It was batch modified for milestone 1.9.2 (but maybe an empty milestone was more appropriate; feel free to change it).

[sjoelund.se]

Milestone changed to 1.9.3 since 1.9.2 was released.

[sjoelund.se]

Moved to new milestone 1.9.4

[sjoelund.se]

Milestone pushed to 1.9.5

[sjoelund.se]

Milestone renamed

[sjoelund.se]

Ticket retargeted after milestone closed

[sjoelund.se]

Milestone moved to 1.12.0 due to 1.11.0 already being released.

[casella]

The milestone of this ticket has been reassigned to "Future".

If you think the issue is still valid and relevant for you, please select milestone 1.13.0 for back-end, code generation and run-time issues, or 2.0.0 for front-end issues.

If you are aware that the problem is no longer present, please select the milestone corresponding to the version of OMC you used to check that, and set the status to "worksforme".

In both cases, a short informative comment would be welcome.

[wbraun]

This seems to be fixed in the meanwhile.

[yahooprimkins@…]

This problem seems not fixed. The problem can be seen in the 1.14 official release version.

[Karim.Abdelhak]

Tested it with 1.16.0~dev-95-g92c3b53 (nightly) and it seems to work fine (see attached files test_res.mat and test_res.png). At it least it does what i expected. Could you attach your results?

I downloaded the three files and just run it from terminal on ubuntu.

EDIT: Ah no ... i looked at the wrong line in the plot, you are right it seems wrong!

[Karim.Abdelhak]

@lochel, @AnHeuermann, could you have a look at this?

[AnHeuermann]

The FMI import is deprecated, use OMSimulator instead.
We should add a warning for this, since it simply doesn't work.
But I am not completely sure how to do this with OMSimulator scripting and OMEdit keeps crashing when I try to use it (see #5785).

Replacing when change(u) then with when u > pre(u) or u < pre(u) then or when u>pre(u) then doesn't help here.

So it is probably no problem regarding the change key-word, or the combination of two condition literals.

[casella]

Replying to AnHeuermann:

The FMI import is deprecated, use OMSimulator instead.
We should add a warning for this, since it simply doesn't work.

Absolutely!

However, please see the discussion starting in ticket:5621#comment:20

I don't think that banning FMI import is a good idea.