OMEdit fails to open model, previously Totally Saved

[filip.jezek@…]

Open model with dependencies on some libraries, Save Total, Open the saved file -> error: Unable to load the file/library.

"Only single non-structured entity is allowed to be stored in the file."

This kinda breaks the idea of Save Total, isnt it?

[filip.jezek@…]

The file, saved by Save Total, error during the load.

[Francesco Casella]

@filip, Could you also add the source files that were used to produced the save total'd model? This would allow to actually reproduce the issue

[filip.jezek@…]

@casella Hi Francesco! Sure, here it is ​https://gist.github.com/filip-jezek/5404c3dc3687e31ae932e7bbd479f680

The Model2 contains the Model1. Model2 is TotalSaved into Model2Total. The Model2Total could not be opened.

[Francesco Casella]

@adeas31, can you please take care of this or reassign it to somebody else who could? I'm not sure if this is an OMEdit issue or and interactive environment issue.

Thanks!

[Martin Sjölund]

Yes, saveTotal is not intended to use in OMEdit but rather in mos-scripting. OMEdit only accepts valid Modelica files whereas omc also accepts file with multiple classes on the top-level.

[Francesco Casella]

Ah, ok. I was also puzzled as Filip by the fact that OMEdit won't load Save Total files.

As usual, this is fine, as long as it is documented :)

See ​PR #109, @adeas31 can you please check, merge, and then close the ticket?

Thanks!

[Arinomo <trista.arinomo@…>]

Source Package

[Arinomo <trista.arinomo@…>]

Initial Model

[Arinomo <trista.arinomo@…>]

Save Total Model

[Arinomo <trista.arinomo@…>]

This error happened to me on 1.14.0-dev-26584-gae23951b15.

[Arinomo <trista.arinomo@…>]

So does it means, i can't open a model from save total from OMEdit(GUI)?

[Arinomo <trista.arinomo@…>]

DidnT read the whole comments. Sorry

[Francesco Casella]

I just added the documentation of saveFileTotal() to the NF ​PR 314 and to the old FE ​PR 315. Now that's in the documentation, there's no excuse for function abuse :)

@adeas31, can you please merge the PR's and re-close the ticket? Thanks!

[Francesco Casella]

In fact, it would be even better if OMEdit also caught the

Only single non-structured entity is allowed to be stored in the file.

message and printed out something like

Only single non-structured entity is allowed to be stored in the file.
If the file was generated by the API function saveTotalModel(), you can only load it with the API function loadFile() in a script or in the interactive environment, not in OMEdit

[anonymous]

It is a bit strange that we can save through the GUI a file that we cannot read back through the GUI itself.

If the saved total is not a "valid modelica file" (comment 4) maybe it would have a different extension (say mot)?
In that case opening a "mot" file could be done using the code currently used for loadFile() in a script.
As far as I can tell this should be straightforward to implement given the existing loadFile() code.

The only drawback is that the "mot" would be an internal OM standard, not a Modelica standard format. But it is already like this, isn't it?

[Francesco Casella]

Replying to anonymous:

It is a bit strange that we can save through the GUI a file that we cannot read back through the GUI itself.

Indeed.

If the saved total is not a "valid modelica file" (comment 4) maybe it would have a different extension (say mot)?

That's a good idea.

In that case opening a "mot" file could be done using the code currently used for loadFile() in a script.

See my comment in ​PR 314

As far as I can tell this should be straightforward to implement given the existing loadFile() code.

The only drawback is that the "mot" would be an internal OM standard, not a Modelica standard format. But it is already like this, isn't it?

Indeed.

[massimo ceraolo]

In that case opening a "mot" file could be done using the code currently used for loadFile() in a script.

Not sure that this was clear enough.
I meant that using the same code of loadFile() in script should be easy to implement a GUI loading routine for "mot". This way, I think, the existing command open Model/Library Files() could be used to read such "mot" files.

[Filip Ježek]

Well, as I see, the problem is not in the improper usage of saveTotal, but in OM not importing a valid modelica file. Consider file test.mo:

model A
Boolean a = true;
end A;

model B
Boolean b = false;
end B;

that is, two models without encapsulated package. Dymola loads fine, OM raises an error and fails to open it. I was unable (please point me out otherwise) a clause in Modelica specification which disallows this.

The motivation is opening a number of supporting libraries within one file, which is simply generated (from both OM and other tools, such as Dymola). The workaround is writing a mos doing this, but still: OM is unable to open a valid .MO.

[Francesco Casella]

Replying to Filip Ježek:

Well, as I see, the problem is not in the improper usage of saveTotal, but in OM not importing a valid modelica file. Consider file test.mo:

model A
Boolean a = true;
end A;

model B
Boolean b = false;
end B;

that is, two models without encapsulated package. Dymola loads fine, OM raises an error and fails to open it. I was unable (please point me out otherwise) a clause in Modelica specification which disallows this.

See Section 13.2.: "package/classes are mapped into directories or files" (i.e., one directory or one file for each package or class, as I understand it).

See also Section 13.2.2.2:

• When mapping a package or class-hierarchy to a file [e.g. the file A.mo ], that file shall only define a single class [ A ] with a name matching the name of the nonstructured entity.

• A ".mo" file defining more than one class cannot be part of the mapping to file-structure and it is an error if it is loaded from the MODELICAPATH

[Filip Ježek]

Ok, thanks for pointing me, i clearly overlooked that. That solves the issue then.
F/

[Martin Sjölund]

Well. It might be that OMEdit should ask the user if the file should be opened (read-only) anyway. That should not interfere with its ability to save the file again...

[Francesco Casella]

We are trying to adhere strictly to the specification. From this point of view, I guess OMC should not accept a .mo file which is invalid according to it.

I am personally in favour of the .mot file option.