[OMEdit] Do not allow the simulation window to be closed if the simulation is still running

[Adrian Pop]

For simulations is would be good not to be able to close the simulation window (btw, how do you get it back if you closed it?).

Especially for simulations that give some asserts at initialization but then continue is hard for the user to tell if the simulation failed or is actually continuing. The user closes the window, does some model modification and then recompiles one would get a "permision denied" when the gcc linker ld tries to write the executable again. OMEdit knows that the exe is still running, it should not let the user recompile the model.

[Francesco Casella]

I understand you mean that you should only be allowed to cancel the simulation with the button (which sends a terminate signal to the executable), but not by closing the window with the window close button, right?

Can't we just interpret also that action as "close the window and terminate the simulation"?

[Adeel Asghar]

Both solutions are possible. We can disable (not sure if the top right cross button can be disabled but for sure we can drop the event) closing the window if simulation is running OR cancel the simulation if users closes the window.

For simulations is would be good not to be able to close the simulation window (btw, how do you get it back if you closed it?).

They are placed in Simulation Setup->Archived Simulations.

[Adeel Asghar]

Done in 5727cb1/OpenModelica.

The user can't close the simulation output window while the model is compiling or simulating.

[Francesco Casella]

Just a comment. I am fine with this feature in principle. However, there are cases where the simulation gets stuck (i.e. because of chattering, or simply because it just takes forever to reach stopTime for any reason and you want to stop it). In these cases, we need a way to eventually stop the simulation and get rid of this window witout the need to kill the OMEdit process or to reboot the computer.

This is a MWE of such a situation

model Chattering
  Real x(start = 1, fixed = true);
equation
  der(x) = noEvent(if x > 0 then -1 else 1);
annotation(experiment(StopTime = 2));
end Chattering;

I just tried it with the latest nightly, and indeed I can stop the simulation by clicking on the Cancel Simulation button. I get this error message

Process crashed
Simulation process failed. Exited with code 62097.

which is not particularly nice, I would have preferred something more polite like

Simulation process terminated by the user at time = 0.5

but this is another story, I'll open a ticket about that.

The question is: are we reasonably sure that the Cancel Simulation button sends a powerful enough termination signal to the simulation executable, so that it basically always works?

[Adeel Asghar]

See #5926 for more further details.