Opened 4 years ago

Closed 4 years ago

#5949 closed defect (fixed)

SimpleModelicaParser does stack overflow on huge arrays

Reported by: adrpo Owned by: sjoelund.se
Priority: high Milestone: 1.16.0
Component: Parser Version:
Keywords: Cc:

Description (last modified by adrpo)

Basically it does diffModelicaFileListings on a file with a *HUGE* diagram annotation.

This needs to be rewritten somehow so that it doesn't blow up the stack:

  elseif id==TokenId.LBRACE then
    (tokens, tree) := scan(tokens, tree, TokenId.LBRACE);
    (tokens, tree, b) := LA1(tokens, tree, {TokenId.RBRACE}); // Easier than checking First(expression), etc
    if not b then
      (tokens, tree) := function_arguments(tokens, tree);
    end if;
    (tokens, tree) := scan(tokens, tree, TokenId.RBRACE);

Attachments (1)

BadClassDiagram.mo​ (4.0 MB) - added by adrpo 4 years ago.

Change History (5)

Changed 4 years ago by adrpo

comment:1 Changed 4 years ago by adrpo

Reported by AKIO NATORI via OpenModelica list.

comment:2 Changed 4 years ago by adrpo

  • Description modified (diff)

comment:4 Changed 4 years ago by sjoelund.se

  • Resolution set to fixed
  • Status changed from new to closed

​https://github.com/OpenModelica/OpenModelica/pull/867

Note: See TracTickets for help on using tickets.